Updated DD4TModelBuilder to support arbitrary Multimedia links. This …#16
Open
willprice76 wants to merge 1 commit intomasterfrom
Open
Updated DD4TModelBuilder to support arbitrary Multimedia links. This …#16willprice76 wants to merge 1 commit intomasterfrom
willprice76 wants to merge 1 commit intomasterfrom
Conversation
…cleans up the code significantly as we now can use GetMultiComponentLinks for all multimedia links and no longer need: GetMultiMediaLinks, GetYoutubeVideos, GetImages, GetDownloads. Note that there is a new virtual protected method; ProcessType which contains logic to determine a more specific sub type if a model has a generic Media item property. This logic was previously handled in the GetMultiMediaLinks method and is needed for Teaser, and Article.ArticleBody, which have generic Media properties which can contain Image, YouTube or Download. This method can be overridden in your own ModelBuilder if you want to extend the logic.
Collaborator
Author
|
Oh... and this also fixes issue #11 by the way... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cleans up the code significantly as we now can use GetMultiComponentLinks for all multimedia links and no longer need: GetMultiMediaLinks, GetYoutubeVideos, GetImages, GetDownloads. Note that there is a new virtual protected method; ProcessType which contains logic to determine a more specific sub type if a model has a generic Media item property. This logic was previously handled in the GetMultiMediaLinks method and is needed for Teaser, and Article.ArticleBody, which have generic Media properties which can contain Image, YouTube or Download. This method can be overridden in your own ModelBuilder if you want to extend the logic.
This fixes issue #15